|
Home > Archive > PostgreSQL JDBC > July 2005 > Re: patch to fix jdk 2 compile errors and v2 compatability
You are viewing an archived Text-only version of the thread.
To view this thread in it's original format and/or if you want to reply to
this thread please [click here]
| Author |
Re: patch to fix jdk 2 compile errors and v2 compatability
|
|
| Oliver Jowett 2005-07-08, 7:24 am |
| Dave Cramer wrote:
> I've tested this against 7.2, 7.4, 8.0, 8.1 with both jdk 1.4, and 1.3.1
Why the duplicated code in Jdbc2CallableStateme
nt /
Jdbc3CallableStateme
nt? Shouldn't this live in AbstractJdbc2Stateme
nt?
-O
---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?
http://www.postgresql.org/docs/faq
| |
| Oliver Jowett 2005-07-08, 9:23 am |
| Dave Cramer wrote:
> Yes it could actually, although, I'd like to separate the knowledge of
> CallableStatement differences somewhere else.
If you mean JDBC2 vs JDBC3 differences, that's what
AbstractJdbc3Stateme
nt is for, surely?
> I agree there's no reason
> for duplicate code though. On the other hand, only one of these classes
> ever gets compiled.
It is a maintenance issue, not a code size / compilation issue. If you
have two copies of the "same" code, you have to keep them in sync by
hand, which is asking for trouble.
-O
---------------------------(end of broadcast)---------------------------
TIP 4: Have you searched our list archives?
http://archives.postgresql.org
| |
| Dave Cramer 2005-07-13, 7:23 am |
| Kris,
I did commit a change which removed the implementations from
CallableStatement. Is it still not compiling ?
Dave
On 13-Jul-05, at 2:20 AM, Kris Jurka wrote:
>
>
> On Fri, 8 Jul 2005, Dave Cramer wrote:
>
>
>
> Note that the current cvs code also fails to compile with the 1.5 JDK
> because you've implemented this in Jdbc3CallableStateme
nt, but not
> Jdbc3gCallableStatem
ent. This is just further argument for putting
> it in
> the proper place.
>
> Kris Jurka
>
> ---------------------------(end of
> broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings
>
>
---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql
.org so that your
message can get through to the mailing list cleanly
|
|
|
|
|