|
Home > Archive > PostgreSQL JDBC > July 2005 > Re: patch to fix jdk 2 compile errors and v2 compatability for review
You are viewing an archived Text-only version of the thread.
To view this thread in it's original format and/or if you want to reply to
this thread please [click here]
| Author |
Re: patch to fix jdk 2 compile errors and v2 compatability for review
|
|
| Dave Cramer 2005-07-08, 9:23 am |
| Oliver,
Yes it could actually, although, I'd like to separate the knowledge
of CallableStatement differences somewhere else. I agree there's no
reason for duplicate code though. On the other hand, only one of
these classes ever gets compiled.
Dave
On 8-Jul-05, at 7:29 AM, Oliver Jowett wrote:
> Dave Cramer wrote:
>
>
> Why the duplicated code in Jdbc2CallableStateme
nt /
> Jdbc3CallableStateme
nt? Shouldn't this live in AbstractJdbc2Stateme
nt?
>
> -O
>
>
Dave Cramer
davec@postgresintl.com
www.postgresintl.com
ICQ #14675561
jabber davecramer@jabber.org
ph (519 939 0336 )
---------------------------(end of broadcast)---------------------------
TIP 4: Have you searched our list archives?
http://archives.postgresql.org
| |
| Dave Cramer 2005-07-08, 11:24 am |
| Yup, I've cut all that code out and moved it. Just testing it as much
as I can now
Dave
On 8-Jul-05, at 10:25 AM, Oliver Jowett wrote:
> Dave Cramer wrote:
>
>
>
> If you mean JDBC2 vs JDBC3 differences, that's what
> AbstractJdbc3Stateme
nt is for, surely?
>
>
>
> It is a maintenance issue, not a code size / compilation issue. If you
> have two copies of the "same" code, you have to keep them in sync by
> hand, which is asking for trouble.
>
> -O
>
>
---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings
|
|
|
|
|