Home > Archive > PostgreSQL Bugs > November 2005 > BUG #2072: CPPFLAGS clobbered









You are viewing an archived Text-only version of the thread. To view this thread in it's original format and/or if you want to reply to this thread please [click here]

 

Author BUG #2072: CPPFLAGS clobbered
Keith Randall

2005-11-26, 9:23 am


The following bug has been logged online:

Bug reference: 2072
Logged by: Keith Randall
Email address: randallk@gmail.com
PostgreSQL version: 8.1.0
Operating system: Linux
Description: CPPFLAGS clobbered
Details:

In src/template/linux the
CPPFLAGS="-D_GNU_SOURCE"
overrides command-line CPPFLAGS
I change it to
CPPFLAGS="$CPPFLAGS -D_GNU_SOURCE"
and am back in business.

Keith

---------------------------(end of broadcast)---------------------------
TIP 4: Have you searched our list archives?

http://archives.postgresql.org

Tom Lane

2005-11-26, 11:23 am

"Keith Randall" <randallk@gmail.com> writes:
> In src/template/linux the
> CPPFLAGS="-D_GNU_SOURCE"
> overrides command-line CPPFLAGS
> I change it to
> CPPFLAGS="$CPPFLAGS -D_GNU_SOURCE"
> and am back in business.


That's pretty much entirely the wrong way to fix it; or at least it's
inconsistent with the way we handle CFLAGS etc, and doing it this way
would require touching every template not only linux.

I'm thinking that configure.in should handle template CPPFLAGS settings
the same way it handles CFLAGS, ie, command line settings override the
template. Probably LDFLAGS too.

BTW, why do you feel a need to override CPPFLAGS in the first place?

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
choose an index scan if your joining column's datatypes do not
match

Sponsored Links





Also available: Server administration forum archive | Web Design forum archive | Software forum archive | Hardware reviews archive | Programming forum archive

Copyright 2008 droptable.com