| Neil Conway 2005-05-23, 3:24 am |
| This patch fixes various issues that crop up compiling with -Wall:
- include parser/keywords.h in backend/slony1_funcs.c, to make the
declaration of ScanKeywordLookup visible
- make write_void_log() return void -- it's return value has never used,
and in any case write_void_log() didn't actually return a value
- include <sys/wait.h> in slon/slon.c, which is needed to make the
declaration of wait(2) visible
- add a missing return statement to slonik_repair_config
() in
slonik/slonik.c
- initialize the return value of close_log_archive() properly in
slon/remote_worker.c
- remove some unused variable declarations
- fix `elevel' in slon/configoptions. c:set_config_option(
) and
get_config_option(). get_config_option() did not initialize `elevel',
and set_config_option() initialized it incorrectly: find_option() takes
a Postgres error level (e.g. WARNING), not a Slony error level (e.g.
SLON_WARN).
I suggest adding -Wall to the default CFLAGS. (It flags a few more
issues I haven't yet fixed.)
-Neil
|