Slony1 PostgreSQL Replication

Author

Slonik/sed

Dave Page

2005-06-28, 3:24 am

Hi,

Slonik is currently using sed to perform substitutions in the Slony SQL
scripts when creating a cluster. On Windows we can only expect to find
sed on a development box, not on your average server, so Hiroshi has put
together a simple text substitution function to replace sed on Windows.

At them moment the sed code and Hiroshi's code is #ifdef WIN32'd,
however it seems to me that there is little point in having two
substitution methods in the code. Would anyone object if we posted a
patch that used Hiroshi's code on *nix as well as win32?

Regards, Dave

Darcy Buskermolen

2005-06-28, 3:24 am

On Tuesday 28 June 2005 00:27, Dave Page wrote:
> Hi,
>
> Slonik is currently using sed to perform substitutions in the Slony SQL
> scripts when creating a cluster. On Windows we can only expect to find
> sed on a development box, not on your average server, so Hiroshi has put
> together a simple text substitution function to replace sed on Windows.
>
> At them moment the sed code and Hiroshi's code is #ifdef WIN32'd,
> however it seems to me that there is little point in having two
> substitution methods in the code. Would anyone object if we posted a
> patch that used Hiroshi's code on *nix as well as win32?

No objections from me, as a matter of fact I had started on this but wasn't
happy with my results so I placed it on the back shelf to the time being.

>
> Regards, Dave
> ____________________
____________________
_______
> Slony1-general mailing list
> Slony1-general- AuKwsB3Fm+ugFIWk8tvy
RWD2FQJk+8+b@public.gmane.org
> http://gborg.postgresql.org/mailman.../slony1-general

--
Darcy Buskermolen
Wavefire Technologies Corp.

http://www.wavefire.com
ph: 250.717.0200
fx: 250.763.1759

Magnus Hagander

2005-06-28, 7:24 am

> Hi,
>=20
> Slonik is currently using sed to perform substitutions in the=20
> Slony SQL scripts when creating a cluster. On Windows we can=20
> only expect to find sed on a development box, not on your=20
> average server, so Hiroshi has put together a simple text=20
> substitution function to replace sed on Windows.
>=20
> At them moment the sed code and Hiroshi's code is #ifdef=20
> WIN32'd, however it seems to me that there is little point in=20
> having two substitution methods in the code. Would anyone=20
> object if we posted a patch that used Hiroshi's code on *nix=20
> as well as win32?

>From a quick look at things, this is the same code that was put in
initdb when it was converted to C, more or less. Correct?

//Magnus

Dave Page

2005-06-28, 7:24 am

=20

> -----Original Message-----
> From: Magnus Hagander [mailto:mha- +PAb3xVejjn11pZQbBMD
iQ@public.gmane.org]=20
> Sent: 28 June 2005 10:02
> To: Dave Page; slony1-general- AuKwsB3Fm+ugFIWk8tvy
RWD2FQJk+8+b@public.gmane.org
> Subject: RE: [Slony1-general] Slonik/sed
>=20
>=20
> From a quick look at things, this is the same code that was put in
> initdb when it was converted to C, more or less. Correct?

Believe so. Which probably means it's the same code we used in
pgInstaller to rewrite postgresql.conf...

/D

Sponsored Links