Slony1 PostgreSQL Replication - [PATCH] Win32 Build environment

Author

[PATCH] Win32 Build environment

Dave Page

2005-06-28, 8:25 pm

[Please ignore all previous Win32 patches I've posted for review - I'm
reposting updated and combined versions generated again CVS tip]

The attached patch implements a suitable build environment for Win32
using the Mingw/Msys environment used to develop PostgreSQL. Following
application of this patch, the /win32 directory in CVS is redundant and
may be removed. The following points should be noted:

- pg_config returns DOS style paths which GCC doesn't like. To overcome
this, configure should be run with "--with-pgbindir=/usr/local/pgsql/bin
--with-pgincludedir=/usr/local/pgsql/include
--with-pgincludeserverdir=/usr/local/pgsql/include/server"

- Failure of the posix signals test is noted with a warning, but not a
configure failure at this time to allow compilation of working
components (xxid and slony_funcs), and porting of the rest.

Note that I haven't included an updated configure in the patch because
Msys uses 2.59 and wasn't sure if an upgrade was acceptable. I can
provide an update if required though.

Please apply to CVS.

Regards, Dave

Hiroshi Saito

2005-06-28, 8:25 pm

Thanks all.:-)
As for me, a response is slow..

It is the first part.
Does this have a bad influence at the time of other Uni*?

Regards,
Hiroshi Saito

Dave Page

2005-06-29, 7:24 am

-----Original Message-----
From: Hiroshi Saito [mailto:saito- BlLeDYhMEWED+c6HKvR8
e3f5DAMn2ifp@public.gmane.org]
Sent: Wed 6/29/2005 12:53 AM
To: slony1-general- AuKwsB3Fm+ugFIWk8tvy
RWD2FQJk+8+b@public.gmane.org
Cc: Magnus Hagander; Andreas; Dave Page
Subject: Re: [Slony1-general] [PATCH] Win32 Build environment
=20
> Thanks all.:-)
> As for me, a response is slow..
>=20
> It is the first part.

Ahh, I was going to post this one for you as well, however it was =
getting late and I wanted to tweak it a little first as I thought I =
spotted a minor issue.

Perhaps the committers could ignore Hiroshi's Slonik patch for the =
minute please?

> Does this have a bad influence at the time of other Uni*?

Eh? If you're referring to me, then I've finished Uni now. I officially =
graduate on 7th July :-)

Regards, Dave

Jacob Coby

2005-06-29, 9:24 am

Hiroshi Saito wrote:
> Thanks all.:-)
> As for me, a response is slow..
>
> It is the first part.

> +#ifndef WIN32
> + strcpy(m_pgshare, PGSHARE);
> +#else
> + /* This begins to look for share. */
> + strcpy(m_pgshare, get_sharepath(argv[0]));
> +#endif

You have a small memory leak here since get_sharepath malloc()s the
result, but is never free()d. My C is rusty, but I think you should
pass in the char *pgshare plus a size_t size to fill with the sharepath.

The m_ prefix seems out of place in the slony source as well.

--
-Jacob

Hiroshi Saito

2005-06-29, 9:24 am

> > It is the first part.
>
> Ahh, I was going to post this one for you as well, however it was getting late and I wanted to tweak it a little first as I
thought I spotted a minor issue.

Uga... There was my misunderstanding. I go with your plan.

>
>Perhaps the committers could ignore Hiroshi's Slonik patch for the minute please?
....

>
>
> Eh? If you're referring to me, then I've finished Uni now. I officially graduate on 7th July :-)

Probably, My confusion..
I hope that a user doesn't get confused.

Regards,
Hiroshi Saito

Darcy Buskermolen

2005-06-29, 11:24 am

On Wednesday 29 June 2005 03:22, Dave Page wrote:
> -----Original Message-----
> From: Hiroshi Saito [mailto:saito- BlLeDYhMEWED+c6HKvR8
e3f5DAMn2ifp@public.gmane.org]
> Sent: Wed 6/29/2005 12:53 AM
> To: slony1-general- AuKwsB3Fm+ugFIWk8tvy
RWD2FQJk+8+b@public.gmane.org
> Cc: Magnus Hagander; Andreas; Dave Page
> Subject: Re: [Slony1-general] [PATCH] Win32 Build environment
>
>
> Ahh, I was going to post this one for you as well, however it was getting
> late and I wanted to tweak it a little first as I thought I spotted a minor
> issue.
>
> Perhaps the committers could ignore Hiroshi's Slonik patch for the minute
> please?

Opps sorry that is a bit late, I applied this patch (along with your win32
build one) yesterday evening. I do have a few style cleanups and the like
that I want to apply to them, as well as seeing what I can do about removing
the number of #ifdefs to make things a bit cleaner for all of us. This last
item is not in my plans to happen anytime real soon now.

>
>
> Eh? If you're referring to me, then I've finished Uni now. I officially
> graduate on 7th July :-)
>
> Regards, Dave
>
>
>
> ____________________
____________________
_______
> Slony1-general mailing list
> Slony1-general- AuKwsB3Fm+ugFIWk8tvy
RWD2FQJk+8+b@public.gmane.org
> http://gborg.postgresql.org/mailman.../slony1-general

--
Darcy Buskermolen
Wavefire Technologies Corp.

http://www.wavefire.com
ph: 250.717.0200
fx: 250.763.1759

Christopher Browne

2005-06-29, 11:24 am

Darcy Buskermolen wrote:

>On Wednesday 29 June 2005 03:22, Dave Page wrote:
>
>
>
>Opps sorry that is a bit late, I applied this patch (along with your win32
>build one) yesterday evening. I do have a few style cleanups and the like
>that I want to apply to them, as well as seeing what I can do about removing
>the number of #ifdefs to make things a bit cleaner for all of us. This last
>item is not in my plans to happen anytime real soon now.
>
>
FYI, I checked this out (I was thinking of applying it too :-)), and in
view of the changes being in, I ran thru some of the duct tape tests; it
doesn't look like it has broken anything on *Nix...

Dave Page

2005-06-30, 3:24 am

=20

> -----Original Message-----
> From: Darcy Buskermolen [mailto:darcy- QSklyHmfoqpWk0Htik3J
/w@public.gmane.org]=20
> Sent: 29 June 2005 16:35
> To: slony1-general- AuKwsB3Fm+ugFIWk8tvy
RWD2FQJk+8+b@public.gmane.org
> Cc: Dave Page; Hiroshi Saito
> Subject: Re: [Slony1-general] [PATCH] Win32 Build environment
>=20
> On Wednesday 29 June 2005 03:22, Dave Page wrote:
> it was getting
> spotted a minor
> for the minute
>=20
> Opps sorry that is a bit late, I applied this patch (along=20
> with your win32=20
> build one) yesterday evening. I do have a few style=20
> cleanups and the like=20
> that I want to apply to them, as well as seeing what I can do=20
> about removing=20
> the number of #ifdefs to make things a bit cleaner for all of=20
> us. This last=20
> item is not in my plans to happen anytime real soon now.

Ah, well - never mind. The #define cleanup was the main thing I wanted
to look at (in particular, I suspect #define SED... Is now obsolete.

Thanks for applying them.

Regards, Dave.

Dave Page

2005-06-30, 3:24 am

=20

> -----Original Message-----
> From: slony1-general-bounces- AuKwsB3Fm+ugFIWk8tvy
RWD2FQJk+8+b@public.gmane.org=20
> [mailto:slony1-general-bounces- AuKwsB3Fm+ugFIWk8tvy
RWD2FQJk+8+b@public.gmane.org] On=20
> Behalf Of Christopher Browne
> Sent: 29 June 2005 16:40
> To: Darcy Buskermolen
> Cc: slony1-general- AuKwsB3Fm+ugFIWk8tvy
RWD2FQJk+8+b@public.gmane.org
> Subject: Re: [Slony1-general] [PATCH] Win32 Build environment
>=20
> FYI, I checked this out (I was thinking of applying it too=20
> :-)), and in
> view of the changes being in, I ran thru some of the duct=20
> tape tests; it
> doesn't look like it has broken anything on *Nix...

Ah, suddenly it clicks about what Hiroshi meant by Uni* :-)

Regards, Dave

Dave Page

2005-06-30, 3:24 am

=20

> -----Original Message-----
> From: Darcy Buskermolen [mailto:darcy- QSklyHmfoqpWk0Htik3J
/w@public.gmane.org]=20
> Sent: 29 June 2005 16:35
> To: slony1-general- AuKwsB3Fm+ugFIWk8tvy
RWD2FQJk+8+b@public.gmane.org
> Cc: Dave Page; Hiroshi Saito
> Subject: Re: [Slony1-general] [PATCH] Win32 Build environment
>=20
> Opps sorry that is a bit late, I applied this patch (along=20
> with your win32=20
> build one) yesterday evening. =20

It seems the update to src/slonik/Makefile didn't get commited :-(

>From the end of the patch, in case you need it:

Index: src/slonik/Makefile
=3D=3D=3D=3D=3D=3D=3
D=3D=3D=3D=3D=3D=3D=
3D=3D=3D=3D=3D=3D=3D
=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3
D=3D=3D=3D=3D=3D=3D=
3D=3D=3D=3D=3D=3D=3D
=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3
D=3D=3D=3D=3D=3D=3D=
3D=3D=3D=3D
RCS file: /usr/local/cvsroot/slony1/slony1-engine/src/slonik/Makefile,v
retrieving revision 1.15
diff -c -r1.15 Makefile
*** src/slonik/Makefile 2 Jun 2005 16:45:18 -0000 1.15
--- src/slonik/Makefile 28 Jun 2005 20:19:43 -0000
***************
*** 23,28 ****
--- 23,31 ----
ifeq ($(PORTNAME), win)
PROG =3D slonik.exe
endif
+ ifeq ($(PORTNAME), win32)
+ PROG =3D slonik.exe
+ endif
=20
OBJS =3D \
slonik.o \

Dave Page

2005-07-04, 8:24 pm

Hi Darcy,

I dunno if you missed this last time - any chance you (or one of the
other committers) could commit my change to the slonik Makefile that was
missed when my patch was applied. This also makes the /win32 directory
obsolete so it should be removed.

If there are no objections, it would also be useful to see my ducttape
patch applied. I realise you are rewriting the test suite, but it would
make our job porting Slony easier if the existing tests worked on Win32
straight from CVS.

Thanks, Dave.

> -----Original Message-----
> From: slony1-general-bounces- AuKwsB3Fm+ugFIWk8tvy
RWD2FQJk+8+b@public.gmane.org=20
> [mailto:slony1-general-bounces- AuKwsB3Fm+ugFIWk8tvy
RWD2FQJk+8+b@public.gmane.org] On=20
> Behalf Of Dave Page
> Sent: 30 June 2005 09:06
> To: Darcy Buskermolen; slony1-general- AuKwsB3Fm+ugFIWk8tvy
RWD2FQJk+8+b@public.gmane.org
> Subject: RE: [Slony1-general] [PATCH] Win32 Build environment
>=20
> =20
>=20
>=20
> It seems the update to src/slonik/Makefile didn't get commited :-(
>=20
>=20
> Index: src/slonik/Makefile
> =
=3D=3D=3D=3D=3D=3D=3
D=3D=3D=3D=3D=3D=3D=
3D=3D=3D=3D=3D=3D=3D
=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3
D=3D=3D=3D=3D=3D=3D=
3D=3D=3D=3D=3D=3D=3D
=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3
D=3D=3D=3D=3D=3D=3D=
3D=3D=3D=3D
> RCS file:=20
> /usr/local/cvsroot/slony1/slony1-engine/src/slonik/Makefile,v
> retrieving revision 1.15
> diff -c -r1.15 Makefile
> *** src/slonik/Makefile 2 Jun 2005 16:45:18 -0000 1.15
> --- src/slonik/Makefile 28 Jun 2005 20:19:43 -0000
> ***************
> *** 23,28 ****
> --- 23,31 ----
> ifeq ($(PORTNAME), win)
> PROG =3D slonik.exe
> endif
> + ifeq ($(PORTNAME), win32)
> + PROG =3D slonik.exe
> + endif
> =20
> OBJS =3D \
> slonik.o \
>=20
> ____________________
____________________
_______
> Slony1-general mailing list
> Slony1-general- AuKwsB3Fm+ugFIWk8tvy
RWD2FQJk+8+b@public.gmane.org
> http://gborg.postgresql.org/mailman.../slony1-general
>=20

Darcy Buskermolen

2005-07-04, 8:24 pm

On Monday 04 July 2005 13:51, Dave Page wrote:
> Hi Darcy,

I will get tho this one this evening unless someone gets there before me.

\\DB

>
> I dunno if you missed this last time - any chance you (or one of the
> other committers) could commit my change to the slonik Makefile that was
> missed when my patch was applied. This also makes the /win32 directory
> obsolete so it should be removed.
>
> If there are no objections, it would also be useful to see my ducttape
> patch applied. I realise you are rewriting the test suite, but it would
> make our job porting Slony easier if the existing tests worked on Win32
> straight from CVS.
>
> Thanks, Dave.
>
>
> ____________________
____________________
_______
> Slony1-general mailing list
> Slony1-general- AuKwsB3Fm+ugFIWk8tvy
RWD2FQJk+8+b@public.gmane.org
> http://gborg.postgresql.org/mailman.../slony1-general

--
Darcy Buskermolen
Wavefire Technologies Corp.

http://www.wavefire.com
ph: 250.717.0200
fx: 250.763.1759

Darcy Buskermolen

2005-07-04, 8:24 pm

On Monday 04 July 2005 13:51, Dave Page wrote:
> Hi Darcy,
>
> I dunno if you missed this last time - any chance you (or one of the
> other committers) could commit my change to the slonik Makefile that was
> missed when my patch was applied. This also makes the /win32 directory
> obsolete so it should be removed.
>
> If there are no objections, it would also be useful to see my ducttape
> patch applied. I realise you are rewriting the test suite, but it would
> make our job porting Slony easier if the existing tests worked on Win32
> straight from CVS.

These have been applied
:wq

>
> Thanks, Dave.
>
>
> ____________________
____________________
_______
> Slony1-general mailing list
> Slony1-general- AuKwsB3Fm+ugFIWk8tvy
RWD2FQJk+8+b@public.gmane.org
> http://gborg.postgresql.org/mailman.../slony1-general

--
Darcy Buskermolen
Wavefire Technologies Corp.

http://www.wavefire.com
ph: 250.717.0200
fx: 250.763.1759

Dave Page

2005-07-05, 3:23 am

=20

> -----Original Message-----
> From: Darcy Buskermolen [mailto:darcy- QSklyHmfoqpWk0Htik3J
/w@public.gmane.org]=20
> Sent: 05 July 2005 00:50
> To: slony1-general- AuKwsB3Fm+ugFIWk8tvy
RWD2FQJk+8+b@public.gmane.org
> Cc: Dave Page
> Subject: Re: [Slony1-general] [PATCH] Win32 Build environment
>=20
> On Monday 04 July 2005 13:51, Dave Page wrote:
> Makefile that was
> /win32 directory
> my ducttape
> but it would
> worked on Win32
>=20
> These have been applied
> :wq

Great, thanks Darcy.

Regards, Dave

Sponsored Links