|
Home > Archive > Slony1 PostgreSQL Replication > July 2005 > PATCH: autoconf not run for slony-1.1.0,
You are viewing an archived Text-only version of the thread.
To view this thread in it's original format and/or if you want to reply to
this thread please [click here]
| Author |
PATCH: autoconf not run for slony-1.1.0,
|
|
| Len Walter 2005-06-30, 7:25 am |
| G'day,
the attached patch is for the configure script. It seems like autoconf
was not re-run after PACKAGE_VERSION was changed for the slony-1.1.0
release, so make rpm failed because it was looking for the wrong
source tarball.
I've used the attached ./configure to make rpms built against postgres
7.4.8, the version included with RHEL 4
This is my first patch to an OSS project - hope I've got the format right!
Len
| |
| cbbrowne-swQf4SbcV9C7WVzo/KQ3Mw@public.gmane.org 2005-07-01, 8:24 pm |
| >> the attached patch is for the configure script. It seems like autoconf[color=darkr
ed]
We need to have a better resolution for this in the future; the 1.1
releases (beta and RC as well) were to some degree "plagued" with this
problem.
There's some sort of near-recursive problem here, where, at present, we
choose between:
1. Needing to remember to run autoconf and check in changes *before*
tagging, which is "brain-o"-vulnerable, or
2. Needing to run autoconf before trying to use a newly-tagged build.
It seems to me that PACKAGE_VERSION shouldn't need to be so embedded in
autoconf.
The tag surely should be able to be picked up irrespective of doing an
autoconf run...
| |
| Vivek Khera 2005-07-04, 8:24 pm |
|
On Jun 30, 2005, at 7:36 PM, Devrim GUNDUZ wrote:
> I just committed a small fix to the CVS HEAD and REL_1.1_STABLE.
> IMHO it'd be better to run autoconf inside spec file:
>
so that would make the release process more redhat specific? i think
that's bad policy.
|
|
|
|
|