Slony1 PostgreSQL Replication - [PATCH] Improved Win32 libpq detection

Author

[PATCH] Improved Win32 libpq detection

Dave Page

2005-07-07, 7:24 am

The attached patch prevents the use of pg_config when figuring out the
PostgreSQL installation paths on Win32 (because gcc doesn't like the DOS
style paths returned). Instead, default locations for $PG_LIBDIR,
$PG_INCLUDEDIR etc. are assumed relative to the location of the
pg_config binary.

If there are no objections, I will apply this, and an updated version of
the configure script within the next day or so.

Regards, Dave.

Darcy Buskermolen

2005-07-07, 9:23 am

On Thursday 07 July 2005 03:44, Dave Page wrote:
> The attached patch prevents the use of pg_config when figuring out the
> PostgreSQL installation paths on Win32 (because gcc doesn't like the DOS
> style paths returned). Instead, default locations for $PG_LIBDIR,
> $PG_INCLUDEDIR etc. are assumed relative to the location of the
> pg_config binary.

Rather than do it that way, would it make more sence to convert the path
from / to \ where needed inside of the m4 ? Assumptions while thought to be
sound can often lead to looking like an XXX later on.

Just my 2 ct's worth

>
> If there are no objections, I will apply this, and an updated version of
> the configure script within the next day or so.
>
> Regards, Dave.

--
Darcy Buskermolen
Wavefire Technologies Corp.

http://www.wavefire.com
ph: 250.717.0200
fx: 250.763.1759

Dave Page

2005-07-07, 11:24 am

=20

> -----Original Message-----
> From: Darcy Buskermolen [mailto:darcy- QSklyHmfoqpWk0Htik3J
/w@public.gmane.org]=20
> Sent: 07 July 2005 15:55
> To: slony1-general- AuKwsB3Fm+ugFIWk8tvy
RWD2FQJk+8+b@public.gmane.org
> Cc: Dave Page
> Subject: Re: [Slony1-general] [PATCH] Improved Win32 libpq detection
>=20
> On Thursday 07 July 2005 03:44, Dave Page wrote:
> figuring out the
> like the DOS
>=20
> Rather than do it that way, would it make more sence to=20
> convert the path=20
> from / to \ where needed inside of the m4 ? Assumptions=20
> while thought to be=20
> sound can often lead to looking like an XXX later on.
>=20
> Just my 2 ct's worth

Unfortunately it's quite that simple due to the way that Msys mounts
directories to emulate a *nix style filesystem within the windows
filesystem. For example, PostgreSQL is installed in /usr/local/pgsql in
Msys, however:

$ /usr/local/pgsql/bin/pg_config --bindir
C:/msys/1.0/local/pgsql/bin

The real path can be affected not only by the Msys installation location
(and version in the future), but also by the filesystem mount points in
use. I know of at least one major PostgreSQL hacker who keeps his Msys
in a non-standard location that would likely run into problems if we
tried to convert the paths somehow.

I'm open to ideas on how this might be done, but given that the vast
majority of Windows/PostgreSQL users run the pgInstaller distribution, I
suspect it's not worth the effort it would take - and those few users
that might compile from scratch, with non-standard paths, would probably
have no trouble overriding default locations on the configure command
line anyway.

Regards, Dave.

Darcy Buskermolen

2005-07-07, 11:24 am

On Thursday 07 July 2005 08:04, Dave Page wrote:
>
> Unfortunately it's quite that simple due to the way that Msys mounts
> directories to emulate a *nix style filesystem within the windows
> filesystem. For example, PostgreSQL is installed in /usr/local/pgsql in
> Msys, however:
>
> $ /usr/local/pgsql/bin/pg_config --bindir
> C:/msys/1.0/local/pgsql/bin
>
> The real path can be affected not only by the Msys installation location
> (and version in the future), but also by the filesystem mount points in
> use. I know of at least one major PostgreSQL hacker who keeps his Msys
> in a non-standard location that would likely run into problems if we
> tried to convert the paths somehow.

Point noted

>
> I'm open to ideas on how this might be done, but given that the vast
> majority of Windows/PostgreSQL users run the pgInstaller distribution, I
> suspect it's not worth the effort it would take - and those few users
> that might compile from scratch, with non-standard paths, would probably
> have no trouble overriding default locations on the configure command
> line anyway.

True, and I guess eventually there will be a binary installer or something of
that sort for slony which will negate the build from source for 90+% of the
windows users anyway. Hmm speaking of which, is the pg info in the registry
someware ? (I admit I'm clueless when it comes to pg on win32)

>
> Regards, Dave.
> ____________________
____________________
_______
> Slony1-general mailing list
> Slony1-general- AuKwsB3Fm+ugFIWk8tvy
RWD2FQJk+8+b@public.gmane.org
> http://gborg.postgresql.org/mailman.../slony1-general

--
Darcy Buskermolen
Wavefire Technologies Corp.

http://www.wavefire.com
ph: 250.717.0200
fx: 250.763.1759

Dave Page

2005-07-07, 11:24 am

=20

> -----Original Message-----
> From: Darcy Buskermolen [mailto:darcy- QSklyHmfoqpWk0Htik3J
/w@public.gmane.org]=20
> Sent: 07 July 2005 16:31
> To: slony1-general- AuKwsB3Fm+ugFIWk8tvy
RWD2FQJk+8+b@public.gmane.org
> Cc: Dave Page
> Subject: Re: [Slony1-general] [PATCH] Improved Win32 libpq detection
>=20
> True, and I guess eventually there will be a binary installer=20
> or something of=20
> that sort for slony which will negate the build from source=20
> for 90+% of the=20
> windows users anyway.=20

Our group has been tasked with not just porting Slony, but also making
sure there is full support for it in pgAdmin (for those that do not want
to use Slonik on the command line), and that it is included with the
pgInstaller distribution of PostgreSQL as standard. That is actually a 5
minute job, made all the more easier by the fact that Magnus & I wrote
95% of pgInstaller in the first place!=20

> Hmm speaking of which, is the pg info=20
> in the registry=20
> someware ? (I admit I'm clueless when it comes to pg on win32)

pgInstaller writes all it's locations to the registry to aid 3rd party
apps in finding things, however this is now real use to us of course
because we work unix style in Msys when developing/building, whereas
pgInstaller is pure Windows-style when it reaches the end user.

Regards, Dave

Sponsored Links