Home > Archive > Slony1 PostgreSQL Replication > January 2006 > Weird Makefile.port changes









You are viewing an archived Text-only version of the thread. To view this thread in it's original format and/or if you want to reply to this thread please [click here]

 

Author Weird Makefile.port changes
Peter Eisentraut

2006-01-29, 8:24 pm

I'm trying to build packages for the slony 1.1.5 release and I found
something pretty bizarre. For some strange reason, several of the
makefiles in makefiles/Makefile.$(port) where changed along the
following lines:

-sqlmansect = 7
+%.o: %.c
+ $(CC) $(CFLAGS) $(CPPFLAGS) -c -o $@ $<

The log message was "Fixes by DarcyB. Should work a lot better now."

This affects the following files:

makefiles/Makefile.aix
makefiles/Makefile.freebsd
makefiles/Makefile.linux
makefiles/Makefile.openbsd
makefiles/Makefile.solaris
makefiles/Makefile.win32

This change is incomprehensible for three reasons:

1. Why change only six platforms and not the rest?

2. Removing the sqlmansect, albeit not terribly critical, prevents the
man pages to build cleanly.

3. The added rule is a built-in rule in make, so you don't need it.

Please revert these changes.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/
Sponsored Links





Also available: Server administration forum archive | Web Design forum archive | Software forum archive | Hardware reviews archive | Programming forum archive

Copyright 2008 droptable.com