| timbo@cvs.perl.org 2005-12-28, 8:26 pm |
| Author: timbo
Date: Wed Dec 28 13:28:39 2005
New Revision: 2332
Modified:
dbd-oracle/branches/pythian/Changes
dbd-oracle/branches/pythian/Oracle.pm
dbd-oracle/branches/pythian/dbdimp.c
Log:
Fixed undef warnings when connecting with undef $user.
Add 'permissions' hint to OCIInitialize error message.
Modified: dbd-oracle/branches/pythian/Changes
====================
====================
====================
==================
--- dbd-oracle/branches/pythian/Changes (original)
+++ dbd-oracle/branches/pythian/Changes Wed Dec 28 13:28:39 2005
@@ -3,6 +3,7 @@
Fixed csform setting for Oracle 8.0.
Fixed csform setting for some UTF8 cases.
Fixed INTERVAL DAY TO SECOND thanks to Honza Pazdziora.
+ Fixed undef warnings when connecting with undef $user.
Added support for nested cursors in select lists thanks to Charles Jardine.
Added "Trailing Spaces" section to docs thanks to Michael A Chase.
Modified: dbd-oracle/branches/pythian/Oracle.pm
====================
====================
====================
==================
--- dbd-oracle/branches/pythian/Oracle.pm (original)
+++ dbd-oracle/branches/pythian/Oracle.pm Wed Dec 28 13:28:39 2005
@@ -203,6 +203,7 @@ my $ORACLE_ENV = ($^O eq 'VMS') ? 'ORA_
# create a 'blank' dbh
+ $user = '' if not defined $user;
(my $user_only = $user) =~ s:/.*::;
my ($dbh, $dbh_inner) = DBI::_new_dbh($drh, {
'Name' => $dbname,
Modified: dbd-oracle/branches/pythian/dbdimp.c
====================
====================
====================
==================
--- dbd-oracle/branches/pythian/dbdimp.c (original)
+++ dbd-oracle/branches/pythian/dbdimp.c Wed Dec 28 13:28:39 2005
@@ -425,7 +425,7 @@ dbd_db_login6(SV *dbh, imp_dbh_t *imp_db
charsetid, ncharsetid, status );
if (status != OCI_SUCCESS) {
oci_error(dbh, NULL, status,
- "OCIEnvNlsCreate (check ORACLE_HOME and NLS settings etc.)");
+ "OCIEnvNlsCreate. Check ORACLE_HOME env var, NLS settings, permissions, etc.");
return 0;
}
@@ -442,7 +442,7 @@ dbd_db_login6(SV *dbh, imp_dbh_t *imp_db
OCIInitialize_log_st
at(init_mode, 0, 0,0,0, status);
if (status != OCI_SUCCESS) {
oci_error(dbh, NULL, status,
- "OCIInitialize. Check ORACLE_HOME and NLS settings etc.");
+ "OCIInitialize. Check ORACLE_HOME env var, Oracle NLS settings, permissions etc.");
return 0;
}
|